On Fri, Feb 27, 2026 at 1:14 PM Peter Eisentraut <peter@eisentraut.org> wrote:
>
> On 26.02.26 12:06, Ashutosh Bapat wrote:
> > All changes to rewriteGraphTable.c are in 0004.
> >
> > Will squash 0002-0004 into 0001 once you have reviewed those patches.
>
> Ok, these all look good to me.
>
> Except, this error message change
>
> -ERROR: property "ename" of element variable "src" not found
> +ERROR: none of the property graph elements associated with variable
> "src" have property with name "ename" defined
>
> I don't know, that seems quite a complicated message for such a simple
> mistake. Also, properties are associated with labels, not with graph
> elements, so this seems misleading.
>
Hmm, mentioning labels was getting even more complicated, so I had to drop it.
How about the earlier version with "of" replaced with "for"? "property
"ename" for element variable "src" not found. The users can lookup the
labels associated with variable src and figure out what went wrong
themselves? I want to avoid simplistic error that other products give
like "property "ename" not found" since it does not clarify whether
the property is absent in the property graph or is not associated with
labels in the pattern.
--
Best Wishes,
Ashutosh Bapat
