Re: Fix couple of typos - Mailing list pgsql-hackers

From Ashutosh Bapat
Subject Re: Fix couple of typos
Date
Msg-id CAExHW5v8YuTVvN+rru9Bv3opR1FWRDv+LxEkNf-EbH7i=qFOHA@mail.gmail.com
Whole thread Raw
In response to Re: Fix couple of typos  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: Fix couple of typos
List pgsql-hackers
On Mon, Mar 17, 2025 at 4:46 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Mon, Mar 17, 2025 at 3:44 PM vignesh C <vignesh21@gmail.com> wrote:
> >
> > While reviewing another patch, I found a couple of typos:
> > 1) subid should have been pubid in AlterPublicationOwner and
> > AlterPublicationOwner_oid functions.
> > 2) Only tuples with XIDs/MXIDs older than the the
> > FreezeLimit/MultiXactCutoff are frozen in the common case.
> > Should have been"
> > Only tuples with XIDs/MXIDs older than the FreezeLimit/MultiXactCutoff
> > are frozen in the common case.
> >
> > The attached patch has the changes for the same.
> >
>
> The changes look good to me.

+1

However they look unrelated. We should split them in two commits
s/subid/pubid/ to one and s/the the/the/ to another. I also verified
that this is the only occurrence of "the the" in the code base.

--
Best Wishes,
Ashutosh Bapat



pgsql-hackers by date:

Previous
From: "Hayato Kuroda (Fujitsu)"
Date:
Subject: RE: long-standing data loss bug in initial sync of logical replication
Next
From: Amit Kapila
Date:
Subject: Re: Proposal: Deferred Replica Filtering for PostgreSQL Logical Replication