Re: Error in StrategySyncStart() prologue - Mailing list pgsql-hackers

From Ashutosh Bapat
Subject Re: Error in StrategySyncStart() prologue
Date
Msg-id CAExHW5uzZhmbYL+nfomqmOj7BOMw1ZZO8HZkQojidgY-erDw5g@mail.gmail.com
Whole thread Raw
List pgsql-hackers
On Fri, Jan 31, 2025 at 7:38 AM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Thu, Jan 30, 2025 at 05:36:32PM +0900, Michael Paquier wrote:
> > Indeed, your suggestion sounds right.  StrategySyncStart() is only
> > used in BgBufferSync() for the background writer since 9cd00c457e6a,
> > and this commit seems to have missed the comment update.
>
> And done.
> --
> Michael

Thanks a lot.

Your archaeology investigation is correct. I looked through the
changes to the names and signatures of BufferSync and BgBufferSync but
most of them were more than a decade ago. So I was doubtful about this
error being so far in the history. I traced the changes to the
function body but not as far as 8 years back.

--
Best Wishes,
Ashutosh Bapat



pgsql-hackers by date:

Previous
From: wenhui qiu
Date:
Subject: Re: Compression of bigger WAL records
Next
From: Sami Imseih
Date:
Subject: Re: Proposal to Enable/Disable Index using ALTER INDEX (with patch)