pg_decode_message vs skip_empty_xacts and xact_wrote_changes - Mailing list pgsql-hackers

From Ashutosh Bapat
Subject pg_decode_message vs skip_empty_xacts and xact_wrote_changes
Date
Msg-id CAExHW5ujRhbOz6_aTq_jQA8NjeFqq9d_8G9viShWvXx8gdSXiQ@mail.gmail.com
Whole thread Raw
Responses Re: pg_decode_message vs skip_empty_xacts and xact_wrote_changes
List pgsql-hackers
Hi All,
Every pg_decode routine except pg_decode_message  that decodes a
transactional change, has following block
/* output BEGIN if we haven't yet */
if (data->skip_empty_xacts && !txndata->xact_wrote_changes)
{
pg_output_begin(ctx, data, txn, false);
}
txndata->xact_wrote_changes = true;

But pg_decode_message() doesn't call pg_output_begin(). If a WAL
message is the first change in the transaction, it won't have a BEGIN
before it. That looks like a bug. Why is pg_decode_message()
exception?

-- 
Best Wishes,
Ashutosh Bapat



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Clean up command argument assembly
Next
From: Amit Kapila
Date:
Subject: Re: pg_decode_message vs skip_empty_xacts and xact_wrote_changes