Re: Add "format" target to make and ninja to run pgindent and pgperltidy - Mailing list pgsql-hackers

From Ashutosh Bapat
Subject Re: Add "format" target to make and ninja to run pgindent and pgperltidy
Date
Msg-id CAExHW5tuJTmuikfkabWq+mvomucY3iQ_vV-10KAsZWM7Yg6tvg@mail.gmail.com
Whole thread Raw
In response to Add "format" target to make and ninja to run pgindent and pgperltidy  ("Jelte Fennema-Nio" <postgres@jeltef.nl>)
Responses Re: Add "format" target to make and ninja to run pgindent and pgperltidy
List pgsql-hackers
On Wed, Dec 31, 2025 at 5:06 PM Jelte Fennema-Nio <postgres@jeltef.nl> wrote:
>
> This tries to make running formatting a lot easier for committers, but
> primarily for new contributors. You can not format the files by simply
> running one of the folowing:
>
> make format
> ninja -C build format
>

I generally like the idea. Since perltidy is not enforced regularly
(like pgindent), running it usually ends up modifying files which are
not part of the patch. So I avoid it if not necessary. Do you propose
to make it optional?

--
Best Wishes,
Ashutosh Bapat



pgsql-hackers by date:

Previous
From: Nazir Bilal Yavuz
Date:
Subject: Re: Speed up COPY FROM text/CSV parsing using SIMD
Next
From: Kirill Reshke
Date:
Subject: Re: Error position support for ComputeIndexAttrs