On Sat, Jul 4, 2026 at 8:16 PM Noah Misch <noah@leadboat.com> wrote:
>
> On Wed, Jul 01, 2026 at 09:51:13PM +0530, Ashutosh Bapat wrote:
> > On Tue, Jun 30, 2026 at 8:41 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > > Noah Misch <noah@leadboat.com> writes:
> > > > Most of the patch bulk (modest as it is) exists to keep support for dumping
> > > > from beta1. I'm not sure whether it was worth bothering. Breaking dump from
> > > > a beta is without precedent known to me, so I just erred on the side of not
> > > > breaking it. If we were to decide pg_dump could drop support for betas, I'd
> > > > be fine with that.
> > >
> > > > This entails a catversion bump on the v19 branch.
> > >
> > > Those points are not unrelated. If you bump catversion then beta
> > > testers must use pg_upgrade to get from beta1 to beta2, so you should
> > > not drop support for dumping from beta1.
> > >
> > > I could agree with dropping that support after beta2, though. That'd
> > > imply having to update via beta2 to beta3 or later, but I doubt those
> > > hardy enough to test beta1 would have a problem with that.
>
> I agree dropping 19beta1 dump support after beta2 would be reasonable, and I
> hadn't thought of doing so. However, ...
>
> > Should there be two commits one which will be reverted post beta2 and
> > one which will stay after beta2?
>
> ... since the sole benefit would be removing ~25 lines, I don't think a
> followup patch is worth it. I wouldn't object if someone wants to remove that
> code later.
>
As long as the code that needs to be removed after beta2 is clear, I
am fine. If somebody other than the ones involved here want to remove
the code, we should make it easy for them to do so.
>
> > I wondered whether we are missing special handling for PROPGRAPH at
> > other places. I looked at other places where we handle OBJECT_SEQUENCE
> > separately in acl related files. I discovered following missing cases
>
> This probably calls for its own thread; feel free to fork the thread for any
> followup on that.
>
Will do that soon.
--
Best Wishes,
Ashutosh Bapat
