Re: Fix uninitialized copy_data var (src/backend/commands/subscriptioncmds.c) - Mailing list pgsql-hackers

From Ranier Vilela
Subject Re: Fix uninitialized copy_data var (src/backend/commands/subscriptioncmds.c)
Date
Msg-id CAEudQArxzUpB4rA2JvgVV5DVhXAmQGjw6xU83n69ki8gMBLk0w@mail.gmail.com
Whole thread Raw
In response to Re: Fix uninitialized copy_data var (src/backend/commands/subscriptioncmds.c)  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Em seg., 28 de jun. de 2021 às 00:29, Michael Paquier <michael@paquier.xyz> escreveu:
On Mon, Jun 28, 2021 at 10:17:55AM +1000, Peter Smith wrote:
> IIUC for the case ALTER_SUBSCRIPTION_DROP_PUBLICATION it looks like
> the uninitialized copy_data local stack var would remain uninitialized
> (undefined) still at the time it is passed at
> AlterSubscription_refresh(sub, copy_data);

Yes, that's wrong.  AlterSubscription_refresh() would happily look at
this uninitialized value when performing a refresh with this command.
That's the only code path using parse_subscription_options() with this
pattern.  Applied on HEAD.
Hi Michael,
Thank you for this comitt.

regards,
Ranier Vilela

pgsql-hackers by date:

Previous
From: Ranier Vilela
Date:
Subject: Re: Fix uninitialized copy_data var (src/backend/commands/subscriptioncmds.c)
Next
From: David Rowley
Date:
Subject: Re: Numeric multiplication overflow errors