Postgres Pro
Downloads
Home   >   mailing lists

Re: Fix resource leak (src/backend/libpq/be-secure-common.c) - Mailing list pgsql-hackers

From Ranier Vilela
Subject Re: Fix resource leak (src/backend/libpq/be-secure-common.c)
Date
Msg-id CAEudQArcwFzYdGcRk8Tyf2ij0DR7mOoqSJejsa00+SkTjFNHSw@mail.gmail.com
Whole thread Raw
In response to Re: Fix resource leak (src/backend/libpq/be-secure-common.c)  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: Fix resource leak (src/backend/libpq/be-secure-common.c)
List pgsql-hackers
Tree view
Em ter., 2 de abr. de 2024 às 15:31, Daniel Gustafsson <daniel@yesql.se> escreveu:
> On 2 Apr 2024, at 20:13, Ranier Vilela <ranier.vf@gmail.com> wrote:

> Fix by freeing the pointer, like pclose_check (src/common/exec.c) similar case.

Off the cuff, seems reasonable when loglevel is LOG.

Per Coverity.

Another case of resource leak, when loglevel is LOG.
In the function shell_archive_file (src/backend/archive/shell_archive.c)
The pointer *xlogarchcmd*  is not freed.

best regards,
Ranier Vilela
Attachment

pgsql-hackers by date:

Previous
From: Kirill Reshke
Date:
Subject: Re: psql: Greatly speed up "\d tablename" when not using regexes
Next
From: Jelte Fennema-Nio
Date:
Subject: Re: psql: Greatly speed up "\d tablename" when not using regexes