Re: Possible pointer var TupleDesc rettupdesc used not initialized (src/backend/optimizer/util/clauses.c) - Mailing list pgsql-hackers

From Ranier Vilela
Subject Re: Possible pointer var TupleDesc rettupdesc used not initialized (src/backend/optimizer/util/clauses.c)
Date
Msg-id CAEudQAraSRf2ojo3KLZjZNzD2c9Uq-d=Kw9p8NMmz9Dkwb4DPw@mail.gmail.com
Whole thread Raw
In response to Re: Possible pointer var TupleDesc rettupdesc used not initialized (src/backend/optimizer/util/clauses.c)  (Zhihong Yu <zyu@yugabyte.com>)
List pgsql-hackers

Em seg., 24 de mai. de 2021 às 23:35, Zhihong Yu <zyu@yugabyte.com> escreveu:


On Mon, May 24, 2021 at 7:21 PM Ranier Vilela <ranier.vf@gmail.com> wrote:
Em seg., 24 de mai. de 2021 às 22:42, Mark Dilger <mark.dilger@enterprisedb.com> escreveu:


> On May 24, 2021, at 5:37 PM, Ranier Vilela <ranier.vf@gmail.com> wrote:
>
> Hi,
>
> Possible pointer TupleDesc rettupdesc used not initialized?
>
> if (!isNull) at line 4346 taking a true branch, the function check_sql_fn_retval at line 4448 can use rettupdesc uninitialized.

Care to submit a patch?
Hi Mark, sorry but not.
I examined the code and I can't say what the correct value is for rettupdesc.

Hi,
It seems the following call would fill up value for rettupdesc :

functypclass = get_expr_result_type((Node *) fexpr, NULL, &rettupdesc); 
In short, do you suggest running half the else?
To do this, you need to fill fexpr correctly.
It will not always be a trivial solution.
 
regards,
Ranier Vilela


pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: How can the Aggregation move to the outer query
Next
From: Dilip Kumar
Date:
Subject: Re: Assertion failure while streaming toasted data