Request a Demo
Home   >   mailing lists

Simplifies checks (src/bin/pg_dump/pg_backup_archiver.c) - Mailing list pgsql-hackers

From Ranier Vilela
Subject Simplifies checks (src/bin/pg_dump/pg_backup_archiver.c)
Date
Msg-id CAEudQArCHrLpEKHfuH7mRDaN43rughGfND1n+EuvHMx9zJOAuw@mail.gmail.com
Whole thread
Responses Re: Simplifies checks (src/bin/pg_dump/pg_backup_archiver.c)
List pgsql-hackers
Tree view
Hi.

Per Coverity.

Coverity has some alerts about the function *RestoreArchive*,
arguing that there are null variable dereferences.

I haven't done in-depth research to determine if this is correct or not.
However, the code can be simplified to a single check that would silence notifications and protect against this issue.

patch attached.

best regards,
Ranier Vilela
Attachment

pgsql-hackers by date:

Previous
From: Jim Jones
Date:
Subject: Re: ALTER TABLE: warn when actions do not recurse to partitions
Next
From: Robert Haas
Date:
Subject: Re: pg_combinebackup: incorrect size of VM fork after combine