Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH'] Variables assigned with values that is never used. - Mailing list pgsql-hackers

From Ranier Vilela
Subject Re: [PATCH'] Variables assigned with values that is never used.
Date
Msg-id CAEudQAqJ=MVqJd4MHi=iMLismngE4GJqdiEZa1isxF3Pem-udg@mail.gmail.com
Whole thread Raw
In response to [PATCH'] Variables assigned with values that is never used.  (Ranier Vilela <ranier.vf@gmail.com>)
List pgsql-hackers
Tree view
Em sáb., 28 de mar. de 2020 às 10:33, Ranier Vilela <ranier.vf@gmail.com> escreveu:
Hi,

Theses variables, are assigned with values that never is used and, can safely have their values removed.

diff --git a/src/backend/access/nbtree/nbtsplitloc.c b/src/backend/access/nbtree/nbtsplitloc.c
index 8ba055be9e..15ac106525 100644
--- a/src/backend/access/nbtree/nbtsplitloc.c
+++ b/src/backend/access/nbtree/nbtsplitloc.c
@@ -812,7 +812,6 @@ _bt_bestsplitloc(FindSplitData *state, int perfectpenalty,
 
  if (penalty <= perfectpenalty)
  {
- bestpenalty = penalty;
  lowsplit = i;
  break;
  }

Coincidence? I think not.

regards,
Ranier Vilela

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: [DOC] Document concurrent index builds waiting on each other
Next
From: Jehan-Guillaume de Rorthais
Date:
Subject: Re: documenting the backup manifest file format