Em qua., 29 de set. de 2021 às 15:01, Tom Lane <tgl@sss.pgh.pa.us> escreveu:
Alvaro Herrera <alvherre@2ndquadrant.com> writes: > On 2021-Sep-29, Ranier Vilela wrote: >> Em qua., 29 de set. de 2021 às 08:12, Drouvot, Bertrand <bdrouvot@amazon.com> >> escreveu: >> Duplicating functions is very bad for maintenance and bloats the code >> unnecessarily, IMHO.
> Well, there are 42 calls of PushActiveSnapshot currently, and only 6 are > updated in the patch. Given that six sevenths of the calls continue to > use the existing function and that it is less verbose than the new one, > that seems sufficient argument to keep it.
Seeing that we have to back-patch this, changing the ABI of PushActiveSnapshot seems like a complete non-starter.
The idea I'd had to avoid code duplication was to make PushActiveSnapshot a wrapper for the extended function: