Postgres Pro
Downloads
Home   >   mailing lists

Fix Brin Private Spool Initialization (src/backend/access/brin/brin.c) - Mailing list pgsql-hackers

From Ranier Vilela
Subject Fix Brin Private Spool Initialization (src/backend/access/brin/brin.c)
Date
Msg-id CAEudQAqD7f2i4iyEaAz-5o-bf6zXVX-AkNUBm-YjUXEemaEh6A@mail.gmail.com
Whole thread Raw
Responses Re: Fix Brin Private Spool Initialization (src/backend/access/brin/brin.c)
List pgsql-hackers
Tree view
Hi,

The commit b437571 I think has an oversight.
When allocate memory and initialize private spool in function:
_brin_leader_participate_as_worker

The behavior is the bs_spool (heap and index fields)
are left empty.

The code affected is:
  buildstate->bs_spool = (BrinSpool *) palloc0(sizeof(BrinSpool));
- buildstate->bs_spool->heap = buildstate->bs_spool->heap;
- buildstate->bs_spool->index = buildstate->bs_spool->index;
+ buildstate->bs_spool->heap = heap;
+ buildstate->bs_spool->index = index;

Is the fix correct?

best regards,
Ranier Vilela
Attachment

pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: Add the ability to limit the amount of memory that can be allocated to backends.
Next
From: Bruce Momjian
Date:
Subject: Re: Statistics Import and Export