Home > mailing lists

Re: Slow GRANT ROLE on PostgreSQL 16 with thousands of ROLEs - Mailing list pgsql-hackers

From	Ranier Vilela
Subject	Re: Slow GRANT ROLE on PostgreSQL 16 with thousands of ROLEs
Date	March 27 19:21:23
Msg-id	CAEudQApkjBqrrWriKRzRGOwOENVF0aCqJY8XvbeqtN9X9Nxf0A@mail.gmail.com Whole thread Raw
Responses	Re: Slow GRANT ROLE on PostgreSQL 16 with thousands of ROLEs
List	pgsql-hackers

Hi,

Nathan Bossart <nathandbossart(at)gmail(dot)com> writes:

>Committed with that change. Thanks for the guidance on this one.

I think that left an oversight in a commit d365ae7

If the admin_role is a NULL pointer, so, can be dereferenced

in the main loop of the function roles_is_member_of and

worst, IMO, can be destroying aleatory memory?

First, is a better shortcut test to check if admin_role is NOT NULL.

Second, !OidIsValid(*admin_role), It doesn't seem necessary anymore.

Or am I losing something?

best regards,

Ranier Vilela

From: Heikki Linnakangas
Date: 27 March, 19:18:46
Subject: Re: Combine Prune and Freeze records emitted by vacuum

From: Nathan Bossart
Date: 27 March, 19:41:04
Subject: Re: Slow GRANT ROLE on PostgreSQL 16 with thousands of ROLEs