On Thu, Mar 5, 2026 at 9:49 AM Euler Taveira <euler@eulerto.com> wrote:
Don't duplicate code. If you are reusing a function, my advice is to move it to src/common. You can always use "ifdef FRONTEND" to use the appropriate log message (elog/ereport vs pg_error, for example).
I have made all the changes except for this one, and I am deferring to Amit Kapila regarding the marks.
Regarding duplicating code - I was trying to keep the change contained. Is it okay to make that change in a separate check in since it would also touch src/backend/postmaster/syslogger.c?
On Thu, Mar 5, 2026 at 8:19 PM Euler Taveira <euler@eulerto.com> wrote: > > One of the arguments to have this feature was that pg_createsubscriber mixes the > server and tool messages. Couldn't we fix it adding "marks" on the output saying > the server log messages starts here and the server log messages ends here? >
It will simplify the output to some extent but still it will be mixed at different intervals in the LOG which is not good for grepping required info. Also, I am not sure if we use such markers at other places.
