Re: tablecmds: clarify recurse vs recusing - Mailing list pgsql-hackers

From Chao Li
Subject Re: tablecmds: clarify recurse vs recusing
Date
Msg-id CAEoWx2m=dditqdNvwC45HNMmzU0jVvN1_2dsP4ma2Gj4Wu7HhQ@mail.gmail.com
Whole thread Raw
In response to Re: tablecmds: clarify recurse vs recusing  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers


On Jan 21, 2026, at 04:07, Tom Lane <tgl@sss.pgh.pa.us> wrote:

Chao Li <li.evan.chao@gmail.com> writes:
Enhancing the header comments also helps here.
PSA v2:

I had something more like the attached in mind.  I'm not generally
a fan of documenting only some of the arguments of a function, so
I don't care for the way you handled the issue for other functions
in tablecmds.c either.  We can either assume that people read
ATPrepCmd's comment and can extrapolate to the other functions,
or we can do something similar to this for all of them.

Got it, thanks. In v4, I’ve limited the changes to fully documenting all ATPrepCmd() arguments in its header comment and removed the scattered recurse/recursing references from other functions.


I do agree with your 0002, but I see no point in pushing that
separately.

Absolutely. 0002 was too trivial to be a separate commit. I have squashed it into 0001 in v4.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/




Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Some cleanup of pg_stat_statements tests
Next
From: Jacob Champion
Date:
Subject: [PATCH] Reserve protocol 3.1 explicitly in pqcomm.h