Request a Demo
Home   >   mailing lists

Re: backend/nodes cleanup: Move loop variables definitions into for statement - Mailing list pgsql-hackers

From Chao Li
Subject Re: backend/nodes cleanup: Move loop variables definitions into for statement
Date
Msg-id CAEoWx2=q-X6LTpFncGLjZrvcaBwByc165ZNsEg+JrkEWKEMygA@mail.gmail.com
Whole thread Raw
In response to Re: backend/nodes cleanup: Move loop variables definitions into for statement  (Chao Li <li.evan.chao@gmail.com>)
Responses Re: backend/nodes cleanup: Move loop variables definitions into for statement
List pgsql-hackers
Tree view

On Tue, Nov 25, 2025 at 7:38 AM Chao Li <li.evan.chao@gmail.com> wrote:

On Mon, Nov 24, 2025 at 11:00 PM Peter Eisentraut <peter@eisentraut.org> wrote:
On 19.11.25 11:32, Chao Li wrote:
> On Wed, Nov 19, 2025 at 5:36 PM Peter Eisentraut <peter@eisentraut.org
> <mailto:peter@eisentraut.org>> wrote:
>
>
>
>     In a couple of cases, you are changing the type of the loop variable
>     from Size to int.  I would not expect such a change in a patch of this
>     nature.  If you have a reason to change it, please explain it (but I
>     doubt the change is correct).
>
>
> That was a mistake. I fixed it in v3.

Still not correct in outDatum().


Oops! Fixed in v4.


Rebased to v5. 

Chao Li (Evan)
---------------------
HighGo Software Co., Ltd.
Attachment

pgsql-hackers by date:

Previous
From: Peter Smith
Date:
Subject: Re: Proposal: Conflict log history table for Logical Replication
Next
From: Pavel Stehule
Date:
Subject: Re: proposal: schema variables