Re: amcheck verification for GiST - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: amcheck verification for GiST
Date
Msg-id CAEepm=2vmjiOPk4nA6ttfCeu4TvsY+1dg8u=pJBcaSWbNVu2Cg@mail.gmail.com
Whole thread Raw
In response to amcheck verification for GiST  (Andrey Borodin <x4mmm@yandex-team.ru>)
Responses Re: amcheck verification for GiST
Re: amcheck verification for GiST
List pgsql-hackers
On Sun, Sep 23, 2018 at 10:15 PM Andrey Borodin <x4mmm@yandex-team.ru> wrote:
> Here's the patch with amcheck functionality for GiST.

Hi Andrey,

Windows doesn't like it[1]:

contrib/amcheck/verify_gist.c(163): error C2121: '#' : invalid
character : possibly the result of a macro expansion
[C:\projects\postgresql\amcheck.vcxproj]

That's:

+    MemoryContext mctx = AllocSetContextCreate(CurrentMemoryContext,
+ "amcheck context",
+#if PG_VERSION_NUM >= 110000
+ ALLOCSET_DEFAULT_SIZES);
+#else
+ ALLOCSET_DEFAULT_MINSIZE,
+ ALLOCSET_DEFAULT_INITSIZE,
+ ALLOCSET_DEFAULT_MAXSIZE);
+#endif

Not sure what's gong on there... perhaps it doesn't like you to do
that in the middle of a function-like-macro invocation
(AllocSetContextCreate)?

[1] https://ci.appveyor.com/project/postgresql-cfbot/postgresql/build/1.0.14056

-- 
Thomas Munro
http://www.enterprisedb.com


pgsql-hackers by date:

Previous
From: Haribabu Kommi
Date:
Subject: Re: New function pg_stat_statements_reset_query() to reset statisticsof a specific query
Next
From: Andres Freund
Date:
Subject: Re: amcheck verification for GiST