Re: [HACKERS] Support to COMMENT ON DATABASE CURRENT_DATABASE - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: [HACKERS] Support to COMMENT ON DATABASE CURRENT_DATABASE
Date
Msg-id CAEepm=2EZsZox_cLEpYQtrhMmyiDwh0p58_C+A0MMC3TTO2aNQ@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Support to COMMENT ON DATABASE CURRENT_DATABASE  (Jing Wang <jingwangian@gmail.com>)
Responses Re: [HACKERS] Support to COMMENT ON DATABASE CURRENT_DATABASE  (Jing Wang <jingwangian@gmail.com>)
List pgsql-hackers
On Tue, Sep 12, 2017 at 1:11 PM, Jing Wang <jingwangian@gmail.com> wrote:
> Please find the rebased patch based on latest version in the attached file.

Hi Jing

It looks like you created dbname.sql and dbname.out files for a
regression test but forgot to "git add" them to your branch before you
created the patch, so "make check" fails with the patch applied:

test identity                 ... ok
test event_trigger            ... ok
test stats                    ... ok
test dbname                   ... /bin/sh: 1: cannot open
/home/travis/build/postgresql-cfbot/postgresql/src/test/regress/sql/dbname.sql:
No such file

+ printf("target = %s\n",target);

Looks like a stray debugging message?

-- 
Thomas Munro
http://www.enterprisedb.com


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

pgsql-hackers by date:

Previous
From: "Bossart, Nathan"
Date:
Subject: Re: [HACKERS] [Proposal] Allow users to specify multiple tables inVACUUM commands
Next
From: Jing Wang
Date:
Subject: Re: [HACKERS] Support to COMMENT ON DATABASE CURRENT_DATABASE