Re: pgsql: Fix handling of HBA ldapserver with multiple hostnames. - Mailing list pgsql-committers

From Thomas Munro
Subject Re: pgsql: Fix handling of HBA ldapserver with multiple hostnames.
Date
Msg-id CAEepm=1EW00VuUQw5Xkz6i3Dd-DfD5ngbFVSw9a-0zkODb-EmA@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Fix handling of HBA ldapserver with multiple hostnames.  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Fix handling of HBA ldapserver with multiple hostnames.
List pgsql-committers
On Tue, Nov 13, 2018 at 6:37 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Thomas Munro <tmunro@postgresql.org> writes:
> > Fix handling of HBA ldapserver with multiple hostnames.
>
> longfin thinks this has a problem with const-ness:
>
> auth.c:2380:10: error: passing 'const char *' to parameter of type 'void *' discards qualifiers
[-Werror,-Wincompatible-pointer-types-discards-qualifiers]
>                         pfree(hostname);
>                               ^~~~~~~~

Thanks, fixing.  Embarassingly, I had turned off -Werror for this
because my Mac spews strange warnings when you use OpenLDAP, a problem
to which there must be a better solution.

-- 
Thomas Munro
http://www.enterprisedb.com


pgsql-committers by date:

Previous
From: Amit Kapila
Date:
Subject: pgsql: Fix the initialization of atomic variable introduced by the
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Fix handling of HBA ldapserver with multiple hostnames.