Re: Odd 9.4, 9.3 buildfarm failure on s390x - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: Odd 9.4, 9.3 buildfarm failure on s390x
Date
Msg-id CAEepm=09th1L26qmQtjVyYiHyy++D86KHndLNVAA+z24p5ZnTg@mail.gmail.com
Whole thread Raw
In response to Re: Odd 9.4, 9.3 buildfarm failure on s390x  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Odd 9.4, 9.3 buildfarm failure on s390x  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Fri, Oct 5, 2018 at 3:12 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Here's a draft patch against HEAD for this.

+ * Invert the sign of a qsort-style comparison result, ie, exchange negative
+ * and positive integer values, being careful not to get the wrong answer
+ * for INT_MIN.  The argument should be an integral variable.
+ */
+#define INVERT_SIGN(var) \
+    ((var) = ((var) < 0) ? 1 : -(var))

I suppose someone might mistake this for a function that converts -42
to 42... would something like INVERT_COMPARE_RESULT() be better?

-- 
Thomas Munro
http://www.enterprisedb.com


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Odd 9.4, 9.3 buildfarm failure on s390x
Next
From: Tom Lane
Date:
Subject: Re: Odd 9.4, 9.3 buildfarm failure on s390x