Re: [COMMITTERS] pgsql: Allow a partitioned table to have a default partition. - Mailing list pgsql-committers

From Thomas Munro
Subject Re: [COMMITTERS] pgsql: Allow a partitioned table to have a default partition.
Date
Msg-id CAEepm=0-AYqx-3+csErib2zTDtQq7s7J2K6a758xRRaeLCkP3g@mail.gmail.com
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Allow a partitioned table to have a default partition.  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [COMMITTERS] pgsql: Allow a partitioned table to have a default partition.  (Thomas Munro <thomas.munro@enterprisedb.com>)
List pgsql-committers
On Sat, Sep 9, 2017 at 9:49 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Robert Haas <rhaas@postgresql.org> writes:
>> Allow a partitioned table to have a default partition.
>
> Early buildfarm returns not good.
>
> It passes here, so the problem isn't obvious.

map_partition_varattnos() doesn't always write to *found_whole_row, so
it's uninitialised here in generate_partition_qual():
   result = map_partition_varattnos(result, 1, rel, parent,                                    &found_whole_row);   /*
Therecan never be a whole-row reference here */   if (found_whole_row)       elog(ERROR, "unexpected whole-row
referencefound in partition key");
 

-- 
Thomas Munro
http://www.enterprisedb.com


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [COMMITTERS] pgsql: Allow a partitioned table to have a default partition.
Next
From: Thomas Munro
Date:
Subject: Re: [COMMITTERS] pgsql: Allow a partitioned table to have a default partition.