[HACKERS] PG10 Partitioned tables and relation_is_updatable() - Mailing list pgsql-hackers

From Dean Rasheed
Subject [HACKERS] PG10 Partitioned tables and relation_is_updatable()
Date
Msg-id CAEZATCXnbiFkMXgF4Ez1pmM2c-tS1z33bSq7OGbw7QQhHov+6Q@mail.gmail.com
Whole thread Raw
Responses Re: [HACKERS] PG10 Partitioned tables and relation_is_updatable()  (Joe Conway <mail@joeconway.com>)
Re: [HACKERS] PG10 Partitioned tables and relation_is_updatable()  (Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>)
List pgsql-hackers
Hi,

It looks like relation_is_updatable() didn't get the message about
partitioned tables. Thus, for example, information_schema.views and
information_schema.columns report that simple views built on top of
partitioned tables are non-updatable, which is wrong. Attached is a
patch to fix this.

I think this kind of omission is an easy mistake to make when adding a
new relkind, so it might be worth having more pairs of eyes looking
out for more of the same. I did a quick scan of the rewriter code
(prompted by the recent similar omission for RLS on partitioned
tables) and I didn't find any more problems there, but I haven't
looked elsewhere yet.

Regards,
Dean

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Attachment

pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: [HACKERS] RTE_NAMEDTUPLESTORE, enrtuples and comments
Next
From: Christian Ullrich
Date:
Subject: [HACKERS] Buildfarm failures on woodlouse (in ecpg-check)