On 16 September 2013 21:14, Marko Tiikkaja <marko@joh.to> wrote:
> Hi Dean,
>
> First of all, thanks for working on this!
>
> The patch compiles and applies fine (though with offsets). The feature is
> in the SQL standard, and further improves an existing feature.
>
> Some stuff I've spotted and fixed in the attached patch (hope you don't
> mind, thought it'd be easier to just fix these rather than describing them
> in email):
> - Some typos I've spotted in some of the comments
> - Fixed escaping of _ in regression tests
>
> Other than these, the patch looks good to me. Will wait for your thoughts
> and an updated patch before marking ready for committer.
>
Thanks for the review. Those changes all look sensible to me.
Here's an updated patch incorporating all your fixes, and rebased to
apply without offsets.
Regards,
Dean
