Re: wrong results: merge when not matched by source - Mailing list pgsql-bugs

From Dean Rasheed
Subject Re: wrong results: merge when not matched by source
Date
Msg-id CAEZATCVw4RX68r-hd1tXgHtY_AG9y4EBMABuq_+jQX6y1gfVfQ@mail.gmail.com
Whole thread
In response to Re: wrong results: merge when not matched by source  (Tender Wang <tndrwang@gmail.com>)
Responses Re: wrong results: merge when not matched by source
List pgsql-bugs
On Fri, 18 Sept 2026 at 13:52, Tender Wang <tndrwang@gmail.com> wrote:
>
> I also noticed the following part of the comment at the beginning of
> `ExecMerge()`:
>
> If the target tuple gets deleted or a concurrent update causes the join
> quals to fail, it returns a matched status of false and we call
> ExecMergeNotMatched().
>
> With this change, perhaps this part of the comment should also be
> adjusted to distinguish an original `WHEN MATCHED` case from an
> original `WHEN NOT MATCHED BY SOURCE` case.
>
> Do you think it's worth updating this comment as part of the patch?

OK, here is an update doing that.

Since a new v19 beta is about to be released, I'll hold off on pushing
this until later next week.

Regards,
Dean

Attachment

pgsql-bugs by date:

Previous
From: PG Bug reporting form
Date:
Subject: BUG #19701: GIN trigram index loses rows at similarity_threshold 0
Next
From: Michael Paquier
Date:
Subject: Re: BUG #19693: JSON_VALUE/JSON_QUERY PASSING a toasted text value reads the toast pointer instead of the text