Re: ON CONFLICT DO SELECT (take 3) - Mailing list pgsql-hackers

From Dean Rasheed
Subject Re: ON CONFLICT DO SELECT (take 3)
Date
Msg-id CAEZATCVSChU-=V+L9Kc=x49gz9o14RK+2YANM_GUHQ4ETSovUQ@mail.gmail.com
Whole thread Raw
In response to Re: ON CONFLICT DO SELECT (take 3)  ("v@viktorh.net" <v@viktorh.net>)
Responses Re: ON CONFLICT DO SELECT (take 3)
List pgsql-hackers
On Mon, 17 Nov 2025 at 22:07, v@viktorh.net <v@viktorh.net> wrote:
>
> I believe this new patch addresses all the issues found by Jian. I hope another review won’t find quite so much dirt!
>

The latest set of changes look reasonable to me, so I've squashed
those 2 commits together and made an initial stab at writing a more
complete commit message.

I made a quick pass over the code, and I'm attaching a few more
suggested updates. This is mostly cosmetic stuff (e.g., fixing a few
code comments that were overlooked), plus some minor refactoring to
reduce code duplication.

Regards,
Dean

Attachment

pgsql-hackers by date:

Previous
From: Aleksander Alekseev
Date:
Subject: Re: Trying out
Next
From: Fujii Masao
Date:
Subject: Re: [PATCH] Add hints for invalid binary encoding names in encode/decode functions