Re: Optimizing numeric SUM() aggregate - Mailing list pgsql-hackers

From Dean Rasheed
Subject Re: Optimizing numeric SUM() aggregate
Date
Msg-id CAEZATCUu8EN0uSeQCQprsX4qVLWniaZ1GK=3OQTLoZSJUAsz+Q@mail.gmail.com
Whole thread Raw
In response to Re: Optimizing numeric SUM() aggregate  (Dean Rasheed <dean.a.rasheed@gmail.com>)
List pgsql-hackers
On 27 July 2016 at 09:57, Dean Rasheed <dean.a.rasheed@gmail.com> wrote:
> it could be
> coded using something like
>
>     accum->maxdig += NBASE - 1;
>     if (accum->maxdig > (INT_MAX - INT_MAX / NBASE) / (NBASE - 1))
>         Propagate carries...
>

Oops, that's not quite right because maxdig is actually epresents the
max possible value divided by NBASE-1 in mul_var(), so actually it
ought to have been accum->maxdig++ in the first line.

Regards,
Dean



pgsql-hackers by date:

Previous
From: Andrew Borodin
Date:
Subject: Re: Optimizing numeric SUM() aggregate
Next
From: Dean Rasheed
Date:
Subject: Re: Optimizing numeric SUM() aggregate