Re: pgsql: doc: Warn that ts_headline() output is not HTML-safe. - Mailing list pgsql-committers

From Robins Tharakan
Subject Re: pgsql: doc: Warn that ts_headline() output is not HTML-safe.
Date
Msg-id CAEP4nAxj2rnT87iLQu2+HUFadybovwQAx67_W12L0nxXRWRi0g@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: doc: Warn that ts_headline() output is not HTML-safe.  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: doc: Warn that ts_headline() output is not HTML-safe.
List pgsql-committers


On Fri, 2 May 2025 at 06:57, Tom Lane <tgl@sss.pgh.pa.us> wrote:
Robins Tharakan <tharakan@gmail.com> writes:
> On Thu, 1 May 2025 at 19:43, Dean Rasheed <dean.a.rasheed@gmail.com> wrote:
>> doc: Warn that ts_headline() output is not HTML-safe.

> This commit looks harmless, but 2 separate machines are
> failing on this commit (at the same point).

It's hardly likely that a docs-only commit is the cause.  Did you
update the "experimental" compiler on those machines since their last
run?


I agree. I did try to compile postgres (in a separate folder) with the recent-most gcc
but this does seem to be happening even with the latest gcc commit (25921d66424)
checked in ~40 min ago.

For background, the machines are pretty aggressive [1] in updating gcc - retries every 
15 min [2] . So ideally if gcc fixes the issue (or if I fix something stupid in the way I am
compiling gcc etc), the next buildfarm run should automatically go green soon after.

(I tried to auto-update the gcc string in postgres buildfarm programmatically - when 
recompiling gcc - but it just gets too noisy on the members page. Ideally it'd be just
nicer if gcc -v could also give commit string, but I am not sure how to force that yet).

-
robins


2. robins@dell:/opt/gcc$ tail -20 build.log
gcs09da 20250502_0615 - make successful
gcs09da 20250502_0616 - make install successful.
gcs09da 20250502_0616 - Postgres Buildfarm process not running (0). Good.
gcs09da 20250502_0616 - gcc version string has changed from [16.0.0 20250501 (experimental) - b6d37ec1dd2] to [16.0.0 20250501 (experimental) - 87c4460024d]

gcs2d5a 20250502_0630 - git checkout successful.
gcs2d5a 20250502_0630 - git pull successful.
gcs2d5a 20250502_0630 - No change in gcc version. Quitting.

gcs6cc4 20250502_0645 - git checkout successful.
gcs6cc4 20250502_0645 - git pull successful.
gcs6cc4 20250502_0645 - gcc has changed - [87c4460024d] vs [25921d66424]. Recompiling.
gcs6cc4 20250502_0647 - make successful
gcs6cc4 20250502_0648 - make install successful.
gcs6cc4 20250502_0648 - Postgres Buildfarm process not running (0). Good.
gcs6cc4 20250502_0648 - gcc version string has changed from [16.0.0 20250501 (experimental) - 87c4460024d] to [16.0.0 20250501 (experimental) - 25921d66424]

gcs0df0 20250502_0700 - git checkout successful.
gcs0df0 20250502_0700 - git pull successful.
gcs0df0 20250502_0700 - No change in gcc version. Quitting.

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Add missing newlines to PQescapeInternal() messages pre-v16.
Next
From: Noah Misch
Date:
Subject: pgsql: Doc: stop implying recommendation of insecure search_path value.