Re: [Patch] remove duplicated smgrclose - Mailing list pgsql-hackers

From Junwang Zhao
Subject Re: [Patch] remove duplicated smgrclose
Date
Msg-id CAEG8a3L9qHCw3nWT1iwuHdHMcghqLWxDyu+F0ioDZrZJ1d8Ffw@mail.gmail.com
Whole thread Raw
In response to [Patch] remove duplicated smgrclose  (Steven Niu <niushiji@gmail.com>)
Responses Re: [Patch] remove duplicated smgrclose
Re: [Patch] remove duplicated smgrclose
List pgsql-hackers
Hi Steven,

On Wed, Jul 31, 2024 at 11:16 AM Steven Niu <niushiji@gmail.com> wrote:
>
> Hello, hackers,
>
> I think there may be some duplicated codes.
> Function smgrDoPendingDeletes() calls both smgrdounlinkall() and smgrclose().
> But both functions would close SMgrRelation object, it's dupliacted behavior?
>
> So I make this patch. Could someone take a look at it?
>
> Thanks for your help,
> Steven
>
> From Highgo.com
>
>
You change LGTM, but the patch seems not to be applied to HEAD,
I generate the attached v2 using `git format` with some commit message.

--
Regards
Junwang Zhao

Attachment

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: can we mark upper/lower/textlike functions leakproof?
Next
From: Amul Sul
Date:
Subject: Re: pg_verifybackup: TAR format backup verification