Re: [doc] fix a potential grammer mistake - Mailing list pgsql-hackers

From Junwang Zhao
Subject Re: [doc] fix a potential grammer mistake
Date
Msg-id CAEG8a3JgNFR8fQZLCo3LKQP1CuYAnRDxgX5yPVcVwUkUSHjGFA@mail.gmail.com
Whole thread Raw
In response to Re: [doc] fix a potential grammer mistake  (Robert Treat <rob@xzilla.net>)
Responses Re: [doc] fix a potential grammer mistake
List pgsql-hackers
On Thu, Aug 4, 2022 at 12:42 AM Robert Treat <rob@xzilla.net> wrote:
>
> On Wed, Aug 3, 2022 at 11:15 AM Junwang Zhao <zhjwpku@gmail.com> wrote:
> >
> > Attachment is a corrected version based on Tom's suggestion.
> >
> > Thanks.
> >
> > On Wed, Aug 3, 2022 at 9:56 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > >
> > > Erikjan Rijkers <er@xs4all.nl> writes:
> > > > I don't think these  "were"s  are wrong but arguably changing them to
> > > > "have" helps non-native speakers (like myself), as it doesn't change the
> > > > meaning significantly as far as I can see.
> > >
> > > I think it does --- it changes the meaning from passive to active.
> > > I don't necessarily object to rewriting these sentences more broadly,
> > > but I don't think "have issued" is the correct phrasing.
> > >
> > > Possibly "The user issued ..." would work.
> > >
>
> Is there a reason that the first case says "just" issued vs the other
> two cases? It seems to me that it should be removed.
Attachment is a patch with the "just" removed.

Thanks
>
> Robert Treat
> https://xzilla.net



-- 
Regards
Junwang Zhao

Attachment

pgsql-hackers by date:

Previous
From: Matthias van de Meent
Date:
Subject: Re: postgres_fdw: batch inserts vs. before row triggers
Next
From: "Jonathan S. Katz"
Date:
Subject: Re: pg15b2: large objects lost on upgrade