Re: Report bytes and transactions actually sent downtream - Mailing list pgsql-hackers

From Ashutosh Sharma
Subject Re: Report bytes and transactions actually sent downtream
Date
Msg-id CAE9k0PnWMWM7PgcWRwNitcpEDhOnmku2iyrnTDDGbwZ-cL_-4A@mail.gmail.com
Whole thread
In response to Re: Report bytes and transactions actually sent downtream  (Masahiko Sawada <sawada.mshk@gmail.com>)
List pgsql-hackers
Hi Masahiko-san,

On Fri, Jul 3, 2026 at 3:20 AM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>
> Could you swap these patches' order? I think that these patches are
> independent of each other and while we have an agreement on the new
> statistics, we still need discussion for the refactoring part
> (particularly I guess it's better to avoid including pgstatt.h in
> reorderbuffer.h)
>

Thank you for your review comments.

I have swapped the patch order - please see attached.

In the refactoring patch, I also ensured that reorderbuffer.h does not
depend on pgstat.h. To make that possible, I introduced a shared
header, src/include/replication/replslot_stats.h, where
PgStat_ReplSlotStats is defined. Both pgstat.h and reorderbuffer.h
include that header. Hope that helps!

--
With Regards,
Ashutosh Sharma.

Attachment

pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: Batching in executor
Next
From: Roman Khapov
Date:
Subject: Re: DROP INVALID INDEXES command