Request a Demo
Home   >   mailing lists

Re: SLOPE - Planner optimizations on monotonic expressions. - Mailing list pgsql-hackers

From Alexandre Felipe
Subject Re: SLOPE - Planner optimizations on monotonic expressions.
Date
Msg-id CAE8JnxMkBDm8sKkF=+jt7mo0iUcgqGYwKx5p_dHPGVJ3tE+p=A@mail.gmail.com
Whole thread
In response to Re: SLOPE - Planner optimizations on monotonic expressions.  (Alexandre Felipe <o.alexandre.felipe@gmail.com>)
List pgsql-hackers
Tree view


On Sun, Jul 19, 2026 at 2:26 PM Alexandre Felipe <o.alexandre.felipe@gmail.com> wrote:
Thank you for your review Zsolt,

On Fri, Jul 17, 2026 at 10:16 PM Zsolt Parragi <zsolt.parragi@percona.com> wrote:
-               if (enable_slope && index->rel->reloptkind == RELOPT_BASEREL)
+               if (enable_slope)
                {
...
-               if (cpathkey)
-               {
-                       /*
... 
Isn't that cpathkey if/else needed in the !enable_slope case?

*PENDING*

I thought I was disabling only a piece of code that was added
on commit 0004.

I see it now that I closed the if block in the wrong line hehe.

This also addresses two small issues flagged by CF bot on v11.
enable_slope not in postgresql.conf.sample and a declaration after
code on get_2slope_args.

Regards,
Alexandre
Attachment

pgsql-hackers by date:

Previous
From: Kirill Reshke
Date:
Subject: Re: Streaming replication and WAL archive interactions
Next
From: Robert Haas
Date:
Subject: Re: Bypassing cursors in postgres_fdw to enable parallel plans