Hi,
On Wed, Oct 1, 2025 at 2:57 PM Matheus Alcantara
<matheusssilv97@gmail.com> wrote:
>
> On Sun Sep 28, 2025 at 10:17 AM -03, Arseniy Mukhin wrote:
> >> I agree it would be great to have more tests for such cases. As for
> >> the 'committed field' patch, I think we can add a TAP test that shows
> >> that listeners postpone processing of notifications until
> >> notifications were marked as 'committed=false' in case of aborted
> >> transactions. I tried to write one, but have not succeeded yet. Hope
> >> to finish it soon.
> >
> > I finally managed to write a TAP test for it, so there is a new
> > version with the tap test.
> >
> > I also realized that we can increase test coverage in
> > 002_aborted_tx_notifies.pl if notifications of the aborted transaction
> > span several pages. This way we can better test
> > asyncQueueRollbackNotifications(). So I changed
> > 002_aborted_tx_notifies.pl TAP test a bit.
> >
> > And there is a small indentation change in lmgr.h that should fix this
> > git am warning.
> >
> Thanks for the patches.
>
> I've created a CF entry so we can get more reviews and comments:
> https://commitfest.postgresql.org/patch/6095/
>
Thank you.
There is a test failure on CI, so please find the new patch version
with the fix (Makefile was updated a little bit). And I merged 0002
file with tap tests into 0001.
Best regards,
Arseniy Mukhin
