Re: Finalizing read stream users' flag choices - Mailing list pgsql-hackers

From Arseniy Mukhin
Subject Re: Finalizing read stream users' flag choices
Date
Msg-id CAE7r3MJ5NHb1BMo1oCNWmfrG=Ytx-GKX44YNdA21FuQQQeq_Qg@mail.gmail.com
Whole thread Raw
In response to Re: Finalizing read stream users' flag choices  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Hi,

Could you please help to clarify the READ_STREAM_SEQUENTIAL usage
policy. There are several places that use the callback
'block_range_read_stream_cb'. So it means all of them have the same
sequential access pattern. But only one of them (amcheck
verify_heapam) uses READ_STREAM_SEQUENTIAL. Why is it? Is it correct
to say that 'block_range_read_stream_cb' produces a simple enough
pattern so we don't need READ_STREAM_SEQUENTIAL with it? OTOH we know
in advance that we want to read data strictly sequentially, so why not
let OS detect the pattern, if it does a better job as the comment
around READ_STREAM_SEQUENTIAL says. So amcheck usage looks valid too..


Best regards,
Arseniy Mukhin



pgsql-hackers by date:

Previous
From: Srinath Reddy Sadipiralla
Date:
Subject: Re: foreign key on virtual generated column
Next
From: Sergey Fukanchik
Date:
Subject: Is there public API to fetch errcode?