The patch still updates a bunch of .po files. Those are normally refreshed with the translation updates, so they had better be removed. Other than that, the patch looks in good shape to me so switch to "Ready for committer".
Gotcha. Excluded these from the new version of the patch. It's actually same as above but produced with some git :(exclude) magic.
So, to sum up things on this thread, here are the votes about the use of aliases or a pure breakage: - No to aliases, shake the world: Stephen, Tom, David F, Vik, Bruce M => 5 - Yes to aliases: Michael P, Andres, Peter E., Cynthia S, Jim N, Vladimir, Simon R, Fujii-san => 8 If I misunderstood things, please feel free to speak up.
Counting amendments and more votes down the thread:
- no aliases: Stephen, Tom, David F, Vik, Bruce M, David Steele, Robert Haas => 7
- yes to aliases: Michael P, Andres, Peter E., Cynthia S, Jim N, Vladimir, Simon R => 7
- avoid renaming altogether: Fujii-san => 1
Duh. Folks, you are not making it easy. :) Looks like we need one more vote.
-- Vladimir Rusinov Storage SRE, Google Ireland
Google Ireland Ltd.,Gordon House, Barrow Street, Dublin 4, Ireland Registered in Dublin, Ireland Registration Number: 368047
