nitpick about useless floating point division in gimme_edge_table - Mailing list pgsql-hackers

From Mark Dilger
Subject nitpick about useless floating point division in gimme_edge_table
Date
Msg-id CAE-h2TpCxqiYmA4zmEfaHW9VGC+wWEuXoL_R9z9kMfkhiNHntg@mail.gmail.com
Whole thread Raw
Responses Re: nitpick about useless floating point division in gimme_edge_table
List pgsql-hackers
Hackers,

The return value of gimme_edge_table is not used anywhere in the
core code, so far as I can see.  But the value is computed as

  /* return average number of edges per index */
  return ((float) (edge_total * 2) / (float) num_gene);

which involves some floating point math.  I'm not sure that this matters
much, but (1) it deceives a reader of this code into thinking that this
calculation is meaningful, which it is not, and (2) gimme_edge_table is
called inside a loop, so this is happening repeatedly, though admittedly
that loop is perhaps not terribly large.

mark



pgsql-hackers by date:

Previous
From: Andrew Gierth
Date:
Subject: Re: Patch to fix write after end of array in hashed agg initialization
Next
From: Tom Lane
Date:
Subject: Re: Remove useless associativity/precedence from parsers