Re: [pgAdmin4][patch]: RM #3090 pgadmin shows misleading "Queryreturned successfully" with incorrect SQL - Mailing list pgadmin-hackers
Hello,
We tried to reproduce the issue but we were not capable to reproduce it.
What it is strange on the fix is that python is complaining about a different line then the one that was fixed. Maybe this is just a Python thing....
I assume that the fix works, but I would love to see some tests to ensure it is working. Another issue that looks more problematic is the fact that, as per the Redmine issue, when an exception is thrown it sends back a Successful Query message. If this is the case then this fix doesn't look like it is enough to solve the problem.
Thanks
Victoria & Joao
On Mon, Mar 26, 2018 at 9:00 AM Dave Page <dpage@pgadmin.org> wrote:
Thanks, applied.On Mon, Mar 26, 2018 at 11:43 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi Hackers,Please find the attached patch to fix RM #3090 pgadmin shows misleading "Query returned successfully" with incorrect SQL.----Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
pgadmin-hackers by date: