Re: Bug #3083 fix - Mailing list pgadmin-hackers

From Joao De Almeida Pereira
Subject Re: Bug #3083 fix
Date
Msg-id CAE+jja=Pa3QL2XpHQTmaJP1qpvuNy9Mj6U=4BKNNQ4ip7HGE3A@mail.gmail.com
Whole thread Raw
In response to Re: Bug #3083 fix  (Dave Page <dpage@pgadmin.org>)
Responses Re: Bug #3083 fix  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Hi Dave,
That looks like in the surrounding area of the change. We run our pipeline and everything was green.
Can you provide more details, which python version are you using? OS?

Thanks
Joao

On Thu, Mar 29, 2018 at 9:03 AM Dave Page <dpage@pgadmin.org> wrote:
Hi

On Wed, Mar 28, 2018 at 7:06 PM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hey Akshay and Neethu

We refactored the patch to add tests for the resize feature.  We were able to write test cases for the drag event by using spies and setting the rect dimensions.  In cases like this, we can just test some components in order to have enough confidence in the code.  So we isolated the function that implements the behavior of this feature and tested that it was performing as expected.

We ran the patch through the pipelines and all of the tests passed.

I'm consistently seeing the feature test failure below with this patch applied:

======================================================================
FAIL: runTest (pgadmin.feature_tests.view_data_dml_queries.CheckForViewDataTest)
Validate Insert, Update operations in View/Edit data with given test data
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py", line 125, in runTest
    self._verify_row_data(True)
  File "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py", line 325, in _verify_row_data
    self.assertEquals(cells[idx], config_data[str(idx)][1])
AssertionError: u'[null]' != u'1'
- [null]
+ 1


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Joao De Almeida Pereira
Date:
Subject: Re: [pgAdmin4][RM#3155] Allow user to lock the Layout
Next
From: Joao De Almeida Pereira
Date:
Subject: Re: [pgAdmin4][Patch]: RM #3180 Index node is missing from the treeview of the table node