Thanks Shruthi for the new patches!
I can apply v5 on all active branches (i.e master, REL_18, REL_17, REL_16, REL_15, REL_14).
I checked PG's ECPG regression with v5 and v2_test on master, REL_18, REL_17, and REL_16 using both make and meson.
The v5 patch looks good to me now. I only have a few observations on v2_test patch.
Review comments on v2_test:
1. Not able to apply the v2 test patch on PG15 and PG14 branch, appears meson.build for test is not there on these branches. Need to remove all meson related changes for these branches.
2. char val2[5] = "data1"; --> val2's size will not be able to fit '\0' for the string. As size of val2 and number of characters in "data1" are exactly same?
3. "exec sql disconnect;" - Do we need this at the end as we have already disconnected before Test 2.
3. Minor - Do we need "printf("sqlca.sqlcode = %ld\n", sqlca.sqlcode);"? I see all others have it, but not Test 4?
Regards,
Nishant Sharma,
Pune, EDB.
