Re: Import Statistics in postgres_fdw before resorting to sampling. - Mailing list pgsql-hackers

From Corey Huinker
Subject Re: Import Statistics in postgres_fdw before resorting to sampling.
Date
Msg-id CADkLM=dSX5F5BXfSL8WNiV1OB06q0r_DcAWsvchWfPDp+hdzBw@mail.gmail.com
Whole thread Raw
In response to Re: Import Statistics in postgres_fdw before resorting to sampling.  (Etsuro Fujita <etsuro.fujita@gmail.com>)
List pgsql-hackers
You forgot to pass the res to pgfdw_report_error for proper logging.
I fixed this in the patch I posted just before.

+1
 

> I've update the logic that we don't try to fetch attrstats if the reltuples is 0 or -1, and though the comments still mention the difference in server version, the code behaves the same in new versions and old. My thinking is that either value means "you are not going to find attstats" and our reaction is the same either way.

Agree.

pgsql-hackers by date:

Previous
From: Corey Huinker
Date:
Subject: Re: Import Statistics in postgres_fdw before resorting to sampling.
Next
From: Matthias van de Meent
Date:
Subject: Re: [BUG] Excessive memory usage with update on STORED generated columns.