Re: use of SPI by postgresImportForeignStatistics - Mailing list pgsql-hackers

From Corey Huinker
Subject Re: use of SPI by postgresImportForeignStatistics
Date
Msg-id CADkLM=d9q3mMPxMNuO5arj5ipY-3cFajuQWq1h-foBXiaUGmqg@mail.gmail.com
Whole thread
In response to Re: use of SPI by postgresImportForeignStatistics  (Corey Huinker <corey.huinker@gmail.com>)
List pgsql-hackers

My initial concern was that this would bloat up postgres_fdw with type conversion code, but the patch shows that it isn't that bad.

One additional thought - in an offline conversation I had with Robert Haas, he had taken the position that any FDW was likely pulling values across a wire protocol and then synthesizing postgres-looking statistics from that, so going with cstring inputs was fine, possibly preferable. I'm highlighting that we're now passing in NullableDatums in case he wanted to object to that change.

pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: remove pg_spin_delay() from atomics code
Next
From: Tom Lane
Date:
Subject: Re: Centralised architecture detection