Re: Extended Statistics set/restore/clear functions. - Mailing list pgsql-hackers

From Corey Huinker
Subject Re: Extended Statistics set/restore/clear functions.
Date
Msg-id CADkLM=cFrhE76jnqPZz4pBjyA97qfYkDqWUpw1PK7HEfWB+H4w@mail.gmail.com
Whole thread Raw
In response to Re: Extended Statistics set/restore/clear functions.  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Extended Statistics set/restore/clear functions.
List pgsql-hackers


On Sun, Dec 7, 2025 at 8:26 PM Michael Paquier <michael@paquier.xyz> wrote:
On Fri, Dec 05, 2025 at 12:30:38AM -0500, Corey Huinker wrote:
> Attached is a follow-on to Michael's most recent uncommitted patch,
> changing the errors that I see as "impossible" to elogs. However, I agree
> that they don't add significant workload to the translations, and most
> input functions need to avoid any hard error returns lest they be called in
> a soft-error context.

Reporting the state of the parser in these new elogs is OK for me, but
we had more cases that what your patch has been updating.  I have
included all these cases, making the set of error messages a bit more
consistent across the board, and applied the result.
--
Michael

Rebased. Used new palloc0_array() in a few places, and fixed an expected output message that wasn't updated to reflect the changes.
Attachment

pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments
Next
From: Corey Huinker
Date:
Subject: Re: Extended Statistics set/restore/clear functions.