Request a Demo
Home   >   mailing lists

Re: Fix --missing-stats-only false positive for partitioned expression indexes - Mailing list pgsql-hackers

From Corey Huinker
Subject Re: Fix --missing-stats-only false positive for partitioned expression indexes
Date
Msg-id CADkLM=c3UMCPRC3jXzY85kSESUPj29=jqT_gSzqFmrYd9qeTBQ@mail.gmail.com
Whole thread
In response to Re: Fix --missing-stats-only false positive for partitioned expression indexes  (Baji Shaik <baji.pgdev@gmail.com>)
Responses Re: Fix --missing-stats-only false positive for partitioned expression indexes
List pgsql-hackers
Tree view
On Tue, Jun 16, 2026 at 12:26 PM Baji Shaik <baji.pgdev@gmail.com> wrote:
On Tue, Jun 16, 2026 at 11:14 AM Nathan Bossart <nathandbossart@gmail.com> wrote:
I'm curious why you added this check to the beginning and surrounded the
rest with parentheses.  Wouldn't it be better to follow the example of the
surrounding clauses and an "AND NOT p.inherited" somewhere in the middle?

Good point. v2 moves the check inside the EXISTS as
"AND NOT p.inherited", consistent with how the inheritance
sections below handle it.

v2 attached.

Thanks,
Baji Shaik. 

+1

The refactor I was testing differed only in having the new qual one line higher (above the attstattarget check vs below it). Looks good to me.
 

pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: Disable startup progress timeout during standby WAL replay
Next
From: Nathan Bossart
Date:
Subject: Re: Fix --missing-stats-only false positive for partitioned expression indexes