Request a Demo
Home   >   mailing lists

Re: [PATCH] Fix ARM64/MSVC atomic memory ordering issues on Win11 by adding explicit DMB barriers - Mailing list pgsql-hackers

From Dave Cramer
Subject Re: [PATCH] Fix ARM64/MSVC atomic memory ordering issues on Win11 by adding explicit DMB barriers
Date
Msg-id CADK3HHLMwQizkrpRujcXROT1N3wdZPdJStmBxk9EoRUgXmMKmA@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Fix ARM64/MSVC atomic memory ordering issues on Win11 by adding explicit DMB barriers  (Nathan Bossart <nathandbossart@gmail.com>)
List pgsql-hackers
Tree view

On Thu, 20 Nov 2025 at 17:36, Nathan Bossart <nathandbossart@gmail.com> wrote:
I took a quick look at 0001.

+#ifdef _MSC_VER
+#include <intrin.h>
+#else
 #include <arm_acle.h>
 unsigned int crc;

I think you can remove this since we unconditionally do the runtime check
for MSVC.  In any case, the missing #endif seems likely to cause
problems.

--- a/src/port/pg_crc32c_armv8.c
+++ b/src/port/pg_crc32c_armv8.c
@@ -14,7 +14,9 @@
  */
 #include "c.h"

+#ifndef _MSC_VER
 #include <arm_acle.h>
+#endif

Hm.  Doesn't MSVC require intrin.h?

--
nathan


Dave 

pgsql-hackers by date:

Previous
From: Chao Li
Date:
Subject: Re: Allow GUC settings in CREATE SUBSCRIPTION CONNECTION to take effect
Next
From: Chao Li
Date:
Subject: Re: quoteOneName() inconsistency with quote_all_identifiers — replacement API proposed