Re: Reviving the "Stopping logical replication protocol" patch fromVladimir Gordichuk - Mailing list pgsql-hackers

From Dave Cramer
Subject Re: Reviving the "Stopping logical replication protocol" patch fromVladimir Gordichuk
Date
Msg-id CADK3HHJtek=R6QEPMCvaeub64fOGhTeZ9A27LYShsaPTVCpDHA@mail.gmail.com
Whole thread Raw
In response to Re: Reviving the "Stopping logical replication protocol" patch fromVladimir Gordichuk  (Dmitry Dolgov <9erthalion6@gmail.com>)
Responses Re: Reviving the "Stopping logical replication protocol" patch fromVladimir Gordichuk  (Dmitry Dolgov <9erthalion6@gmail.com>)
List pgsql-hackers
Why is this being closed? I did not see the first email looking for clarification.

The history is the original author dropped off the planet (no idea where he is)

I can certainly rebase it.

Dave Cramer


On Fri, 30 Nov 2018 at 18:00, Dmitry Dolgov <9erthalion6@gmail.com> wrote:
> On Mon, Nov 19, 2018 at 4:58 PM Dmitry Dolgov <9erthalion6@gmail.com> wrote:
>
> > On Tue, Jul 24, 2018 at 5:52 PM Dave Cramer <davecramer@gmail.com> wrote:
> >
> > Back in 2016 a patch was proposed that seems to have died on the vine. See https://www.postgresql.org/message-id/flat/CAFgjRd3hdYOa33m69TbeOfNNer2BZbwa8FFjt2V5VFzTBvUU3w@mail.gmail.com
> > for the history and https://commitfest.postgresql.org/10/621/ for the commitfest entry.
> > I've rebased the patches and attached them for consideration.
> > JDBC tests here https://github.com/pgjdbc/pgjdbc/blob/master/pgjdbc/src/test/java/org/postgresql/replication/LogicalReplicationTest.java all pass
>
> Unfortunately the second patch from the series can't be applied anymore, could
> you please rebase it one more time? Other than that it looks strange for me
> that the corresponding discussion stopped when it was quite close to be in a
> good shape, bouncing from "rejected with feedback" to "needs review". Can
> someone from involved people clarify what's the current status of this patch?

Looks like I'm a failure as a neuromancer, since revival didn't happen. I'm
marking it as returned with feedback.

pgsql-hackers by date:

Previous
From: Stephen Frost
Date:
Subject: Re: [PATCH] Log CSV by default
Next
From: Dmitry Dolgov
Date:
Subject: Re: [HACKERS] proposal: schema variables