Re: Binary support for pgoutput plugin - Mailing list pgsql-hackers

From Dave Cramer
Subject Re: Binary support for pgoutput plugin
Date
Msg-id CADK3HH+nT4s8sZC3cBzbr2W64iz7B60TEtWYXc2opsnq08e7NA@mail.gmail.com
Whole thread Raw
In response to Re: Binary support for pgoutput plugin  (Petr Jelinek <petr.jelinek@2ndquadrant.com>)
List pgsql-hackers
OK, before I go too much further down this rabbit hole I'd like feedback on the current code. See attached patch

There is one obvious hack where in binary mode I reset the input cursor to allow the binary input to be re-read
From what I can tell the alternative is to convert the data in logicalrep_read_tuple but that would require moving a lot of the logic currently in worker.c to proto.c. This seems minimally invasive.

and thanks Petr for the tip to use pglogical for ideas.

Thanks,
Dave Cramer




Attachment

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Is it safe to ignore the return value of SPI_finish andSPI_execute?
Next
From: David Rowley
Date:
Subject: Re: Should we warn against using too many partitions?