Re: [PATCH] pg_isready (was: [WIP] pg_ping utility) - Mailing list pgsql-hackers

From Phil Sorber
Subject Re: [PATCH] pg_isready (was: [WIP] pg_ping utility)
Date
Msg-id CADAkt-gVm9rYM_dG0w+MDbC_Zdh+GBX4-GWytWHG7q4BLWBszg@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] pg_isready (was: [WIP] pg_ping utility)  (Fujii Masao <masao.fujii@gmail.com>)
Responses Re: [PATCH] pg_isready (was: [WIP] pg_ping utility)
List pgsql-hackers
On Mon, Jan 28, 2013 at 11:20 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
> Maybe. But I'm not inclined to add new libpq interface at this stage.
> Because we are in the last CommitFest and I'm not sure whether
> we have enough time to implement that. Instead, how about using
> both PQconninfoParse() and PQconndefaults() like uri-regress.c does?
> Or just remove that output message? At least I don't think that the
> information about host and port needs to be output. Which would make
> the code very simpler.
>

I think that output is important as do others up thread. I think it'd
be simpler to just disable dbname's ability to double as conninfo. If
we are looking for easy, that is.

I don't mind duplicating the behavior from conninfo_array_parse() or
uri-regress.c either. I can just put a comment that at some point in
the future we should add a libpq interface for it.

> Regards,
>
> --
> Fujii Masao



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: autovacuum not prioritising for-wraparound tables
Next
From: Tom Lane
Date:
Subject: Re: Number of buckets in a hash join