On Sun, Apr 26, 2026 at 10:07 AM Andrew Dunstan <andrew@dunslane.net> wrote:
On 2026-04-06 Mo 7:39 AM, Andrew Dunstan wrote: > > On 2026-04-05 Su 4:03 PM, Andres Freund wrote: > > >>> But do we really have to create a new database and a new tablespace >>> for these? >>> Database and tablespace creations are quite heavyweight operations. >>> >>> We already have an existing tablespace and an existing database as >>> part of the >>> regression tests. Couldn't you make do with those? >> Didn't do anything about that. >> > > Well, the trouble is that the database test runs a bunch of alter and > revoke statements on the created database, that we probably don't want > to persist on the existing regression database. I could see an > argument for converting this to a TAP test that would only be run > once, given our current very profligate running of the core regression > suite. That goes doubly for the tablespace test, which could also > probably use ALTER TABLESPACE instead of creating a bunch of > tablespaces and then dropping them. > > >
Here's a patch that converts all these into a single TAP test, and reduces the number of tablespace creations.
