Request a Demo
Home   >   mailing lists

Re: Pasword expiration warning - Mailing list pgsql-hackers

From Yuefei Shi
Subject Re: Pasword expiration warning
Date
Msg-id CAD43U4WHJm=UkxbfhxQRxQRxtdtu7AGj77uO2fF78THQWCaYTg@mail.gmail.com
Whole thread Raw
In response to Re: Pasword expiration warning  (Japin Li <japinli@hotmail.com>)
List pgsql-hackers
Tree view
A few review comments for V8.

===
1.
+		if (password_expire_warning > 0 && vuntil < PG_INT64_MAX)
+		{
+			TimestampTz result = (vuntil - now) / USECS_PER_SEC; /* in seconds */
+
+			if (result <= (TimestampTz) password_expire_warning)
+				MyClientConnectionInfo.warning_message =
+						psprintf("your password will expire in %d day(s)", (int) (result / 86400));
+		}
Please consider localization of the warning message.

2. typo fix
a. `Controls how many time ...` should be `Controls how much time ...`.
b. `Sets how many time before password expire to emit ...` should be `Sets how much time before password expires to emit ...`

pgsql-hackers by date:

Previous
From: Japin Li
Date:
Subject: Re: [PATCH] Add pg_get_role_ddl() functions for role recreation
Next
From: li carol
Date:
Subject: 回复: Correct comment wording in extension.c