Re: [HACKERS] RemoveSubscriptionRel uses simple_heap_delete - Mailing list pgsql-hackers

From Masahiko Sawada
Subject Re: [HACKERS] RemoveSubscriptionRel uses simple_heap_delete
Date
Msg-id CAD21AoDjUvS6E_YACXo7qbLbfpU-DpJ9wPv=q5Yww5d4EyGJmA@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] RemoveSubscriptionRel uses simple_heap_delete  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Wed, Jun 14, 2017 at 10:44 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Masahiko Sawada <sawada.mshk@gmail.com> writes:
>> Currently $subject but should we use CatalogTupleDelete() instead?
>> It's actually the same behavior though. Other functions use
>> CatalogTupleXXX(). Attached patch.
>
> Yeah, evidently that patch failed to track the effects of commits
> 2f5c9d9c9 et al, since it wasn't in-tree yet.  Poking around, at
> least statscmds.c has got the same disease.
>

Thank you for fixing it!

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgindent (was Re: [HACKERS] [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run.)
Next
From: Andres Freund
Date:
Subject: Re: [HACKERS] v10beta pg_catalog diagrams